Improve error message for deprecated methods and invalid property access #5446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
commented
Apr 24, 2020
kocsismate
force-pushed
the
consistent-error-messages-non-object
branch
from
edf83da to
3e86a32
Compare
kocsismate
commented
Apr 24, 2020
kocsismate
force-pushed
the
consistent-error-messages-non-object
branch
4 times, most recently
from
41e0a52 to
61f399a
Compare
kocsismate
commented
Apr 26, 2020
3 tasks
morozov
reviewed
May 2, 2020
kocsismate
force-pushed
the
consistent-error-messages-non-object
branch
4 times, most recently
from
63b5baa to
9d400d1
Compare
morozov
reviewed
May 13, 2020
kocsismate
changed the title
nikic
reviewed
May 14, 2020
nikic
reviewed
May 14, 2020
|
While we're here, do we have any common convention on use of ' vs " ? I think the preference is towards ", but I'm not sure on that. |
nikic
reviewed
May 14, 2020
|
@nikic I also prefer |
nikic
reviewed
May 14, 2020
|
This one needs a rebase over the committed changes. |
|
@nikic Finally I did the rebase locally yesterday, without pushing it here, so that CI was not interrupted and I could cherry-pick the first commit to master. But maybe I can do the push now (since I already know the CI result) |
Co-authored-by: Nikita Popov <nikita.ppv@gmail.com>
kocsismate
force-pushed
the
consistent-error-messages-non-object
branch
from
5dc0b36 to
55091e2
Compare
|
Can I now apply the remaining commit? |
|
Oh, sh.. I screwed up the co-authored-by part :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.